dawidwys commented on a change in pull request #6897: [FLINK-9737] [FLINK-8880]
[sql-client] Support defining temporal tables in environment files
URL: https://github.com/apache/flink/pull/6897#discussion_r226986000
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
##########
@@ -185,6 +196,18 @@ class DescriptorProperties(normalizeKeys: Boolean = true)
{
putIndexedVariableProperties(key,
propertySets.asScala.map(_.asScala.toMap))
}
+ /**
+ * Adds an array of properties under a common key.
+ *
+ * The key consumer receives the array key and value for inserting the
array element.
+ */
+ def putArray[E](key: String, values: JList[E], keyConsumer:
BiConsumer[String, E]): Unit = {
Review comment:
Do we need this method? This method looks a bit strange as it does not use
any internal state of the `DescriptorProperties`. It may event not put anything
to the descriptor as the whole insertion logic is covered by the `keyConsumer`.
As it is used only in tests, could we move it there as a utility method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
