aljoscha commented on a change in pull request #6894: [FLINK-7811] Add support 
for Scala 2.12
URL: https://github.com/apache/flink/pull/6894#discussion_r227033132
 
 

 ##########
 File path: tools/releasing/deploy_staging_jars.sh
 ##########
 @@ -41,5 +41,10 @@ cd ..
 echo "Deploying to repository.apache.org"
 
 echo "Deploying Scala 2.11 version"
+./change-scala-version.sh 2.11
 $MVN clean deploy -Prelease,docs-and-source -DskipTests 
-DretryFailedDeploymentCount=10
 
+echo "Deploying Scala 2.12 version"
+./change-scala-version.sh 2.12
 
 Review comment:
   I agree! We have had the same problem when we did Scala 2.10 releases and 
2.11 releases, I think. And to a degree we have it with the different Hadoop 
versions. We already do many different releases from the same commit.
   
   I can introduce a profile for Scala 2.12 that changes the version, but that 
hasn't worked well in the past and there were always problems with the IDE 
setup, that's why I did it like this.
   
   I'm very open to suggestions here. 😅 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to