zentol commented on a change in pull request #6894: [FLINK-7811] Add support
for Scala 2.12
URL: https://github.com/apache/flink/pull/6894#discussion_r227041428
##########
File path: pom.xml
##########
@@ -613,6 +619,61 @@ under the License.
<profiles>
+ <profile>
+ <id>scala-2.12</id>
+ <activation>
+ <property>
+ <name>scala-212</name>
+ </property>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+
<groupId>org.codehaus.mojo</groupId>
+
<artifactId>build-helper-maven-plugin</artifactId>
+ <version>1.12</version>
+ <executions>
+ <execution>
+
<id>regex-property</id>
+ <goals>
+
<goal>regex-property</goal>
+ </goals>
+ <configuration>
+
<name>maven.test.skip</name>
+
<value>${project.artifactId}</value>
+
<regex>(flink-connector-kafka-0.9.*)|(flink-connector-kafka-0.8.*)|(flink-scala-shell.*)</regex>
Review comment:
What exactly does _theoretically_ mean here? Do i understand it correctly
that the connector works but the test infrastructure doesn't? Are the
scala-shell tests failing because the test infrastructure is broken, or because
the shell is in a half-broken state now? (in the latter case I'd exclude it
completely)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
