StephanEwen commented on a change in pull request #6784: [FLINK-7811] Add 
support for Scala 2.12
URL: https://github.com/apache/flink/pull/6784#discussion_r226956325
 
 

 ##########
 File path: 
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala
 ##########
 @@ -227,32 +227,35 @@ object KNN {
 
             // join input and training set
             val crossed = crossTuned.mapPartition {
-              (iter, out: Collector[(FlinkVector, FlinkVector, Long, Double)]) 
=> {
-                for ((training, testing) <- iter) {
 
 Review comment:
   Minor: Can this be changed without changing the indentation of the function 
body?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to