hequn8128 commented on issue #6900: [FLINK-10642][table] fix CodeGen split 
fields errors in special config
URL: https://github.com/apache/flink/pull/6900#issuecomment-432073424
 
 
   @xueyumusic  
   Thanks for fixing the bug. The bug is caused by `private boolean false;` 
which is generated from the `reusableMemberStatements`. Looks good about the 
fix. I think it would be better to add a test to cover this case. 
   
   LGTM, I think we should ask for advice from @twalthr  before merge this 
change.
   Best, Hequn

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to