zhangxinyu1 commented on a change in pull request #6770: [FLINK-10002]
[Webfrontend] WebUI shows jm/tm logs more friendly.
URL: https://github.com/apache/flink/pull/6770#discussion_r227209341
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/TaskManagerStdoutFileHandler.java
##########
@@ -54,7 +55,7 @@ public TaskManagerStdoutFileHandler(
}
@Override
- protected CompletableFuture<TransientBlobKey>
requestFileUpload(ResourceManagerGateway resourceManagerGateway, ResourceID
taskManagerResourceId) {
- return
resourceManagerGateway.requestTaskManagerFileUpload(taskManagerResourceId,
FileType.STDOUT, timeout);
+ protected CompletableFuture<TransientBlobKey>
requestFileUpload(ResourceManagerGateway resourceManagerGateway, ResourceID
taskManagerResourceId, String filename, FileOffsetRange range) {
Review comment:
".out" filename wouldn't be in log list. The log list only includes
filename of all historical logs. If we modify the implement of
`LogListHandler`, we can also get the stdout filename. However, do you think we
should mix them up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
