[
https://issues.apache.org/jira/browse/FLINK-10642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660004#comment-16660004
]
ASF GitHub Bot commented on FLINK-10642:
----------------------------------------
hequn8128 commented on issue #6900: [FLINK-10642][table] fix CodeGen split
fields errors in special config
URL: https://github.com/apache/flink/pull/6900#issuecomment-432073424
@xueyumusic
Thanks for fixing the bug. The bug is caused by `private boolean false;`
which is generated from the `reusableMemberStatements`. Looks good about the
fix. I think it would be better to add a test to cover this case.
LGTM, I think we should ask for advice from @twalthr before merge this
change.
Best, Hequn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CodeGen split fields errors when maxGeneratedCodeLength equals 1
> ----------------------------------------------------------------
>
> Key: FLINK-10642
> URL: https://issues.apache.org/jira/browse/FLINK-10642
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.6.1
> Reporter: xueyu
> Assignee: xueyu
> Priority: Major
> Labels: pull-request-available
>
> Several tests error in special config when setting maxGeneratedCodeLength 1.
> e.g.
> CalcITCase.testFilterOnCustomType:260 ? InvalidProgram Table program cannot
> be...
> JavaTableEnvironmentITCase.testAsFromAndToPojo:394 ? InvalidProgram Table
> prog...
> JavaTableEnvironmentITCase.testAsFromAndToPrivateFieldPojo:421 ?
> InvalidProgram
> JavaTableEnvironmentITCase.testAsFromPojo:288 ? InvalidProgram Table
> program c...
> JavaTableEnvironmentITCase.testAsFromPrivateFieldsPojo:366 ? InvalidProgram
> Ta...
> JavaTableEnvironmentITCase.testAsWithPojoAndGenericTypes:453 ?
> InvalidProgram ...
> TimeAttributesITCase.testPojoSupport:566 ? JobExecution Job execution
> failed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
