[
https://issues.apache.org/jira/browse/FLINK-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660154#comment-16660154
]
ASF GitHub Bot commented on FLINK-10639:
----------------------------------------
asfgit closed pull request #6902: [FLINK-10639][docs] Fix java syntax error in
document
URL: https://github.com/apache/flink/pull/6902
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docs/dev/table/sourceSinks.md b/docs/dev/table/sourceSinks.md
index 0ff71418940..e80a6808387 100644
--- a/docs/dev/table/sourceSinks.md
+++ b/docs/dev/table/sourceSinks.md
@@ -88,7 +88,7 @@ The `BatchTableSource` interface extends the `TableSource`
interface and defines
<div class="codetabs" markdown="1">
<div data-lang="java" markdown="1">
{% highlight java %}
-BatchTableSource<T> extends TableSource<T> {
+BatchTableSource<T> implements TableSource<T> {
public DataSet<T> getDataSet(ExecutionEnvironment execEnv);
}
@@ -116,7 +116,7 @@ The `StreamTableSource` interface extends the `TableSource`
interface and define
<div class="codetabs" markdown="1">
<div data-lang="java" markdown="1">
{% highlight java %}
-StreamTableSource<T> extends TableSource<T> {
+StreamTableSource<T> implements TableSource<T> {
public DataStream<T> getDataStream(StreamExecutionEnvironment execEnv);
}
@@ -374,7 +374,7 @@ The interface looks as follows:
<div class="codetabs" markdown="1">
<div data-lang="java" markdown="1">
{% highlight java %}
-BatchTableSink<T> extends TableSink<T> {
+BatchTableSink<T> implements TableSink<T> {
public void emitDataSet(DataSet<T> dataSet);
}
@@ -402,7 +402,7 @@ The interface looks as follows:
<div class="codetabs" markdown="1">
<div data-lang="java" markdown="1">
{% highlight java %}
-AppendStreamTableSink<T> extends TableSink<T> {
+AppendStreamTableSink<T> implements TableSink<T> {
public void emitDataStream(DataStream<T> dataStream);
}
@@ -432,7 +432,7 @@ The interface looks as follows:
<div class="codetabs" markdown="1">
<div data-lang="java" markdown="1">
{% highlight java %}
-RetractStreamTableSink<T> extends TableSink<Tuple2<Boolean, T>> {
+RetractStreamTableSink<T> implements TableSink<Tuple2<Boolean, T>> {
public TypeInformation<T> getRecordType();
@@ -466,7 +466,7 @@ The interface looks as follows:
<div class="codetabs" markdown="1">
<div data-lang="java" markdown="1">
{% highlight java %}
-UpsertStreamTableSink<T> extends TableSink<Tuple2<Boolean, T>> {
+UpsertStreamTableSink<T> implements TableSink<Tuple2<Boolean, T>> {
public void setKeyFields(String[] keys);
@@ -572,7 +572,7 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
-class MySystemTableSourceFactory extends StreamTableSourceFactory<Row> {
+class MySystemTableSourceFactory implements StreamTableSourceFactory<Row> {
@Override
public Map<String, String> requiredContext() {
diff --git a/docs/dev/types_serialization.md b/docs/dev/types_serialization.md
index a0f497b3911..9bace8cdbee 100644
--- a/docs/dev/types_serialization.md
+++ b/docs/dev/types_serialization.md
@@ -238,7 +238,7 @@ as possible via reflection, using the few bits that Java
preserves (mainly funct
This logic also contains some simple type inference for cases where the return
type of a function depends on its input type:
{% highlight java %}
-public class AppendOne<T> extends MapFunction<T, Tuple2<T, Long>> {
+public class AppendOne<T> implements MapFunction<T, Tuple2<T, Long>> {
public Tuple2<T, Long> map(T value) {
return new Tuple2<T, Long>(value, 1L);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix java syntax error in document
> ---------------------------------
>
> Key: FLINK-10639
> URL: https://issues.apache.org/jira/browse/FLINK-10639
> Project: Flink
> Issue Type: Bug
> Components: Documentation, Table API & SQL
> Affects Versions: 1.6.1, 1.7.0
> Reporter: sunjincheng
> Assignee: Hequn Cheng
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.1, 1.7.0
>
> Attachments: image-2018-10-22-16-54-10-305.png
>
>
> Due to the
> [StreamTableSourceFactory|https://github.com/apache/flink/blob/master/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/StreamTableSourceFactory.scala]
> is a trait. So the java example in the document should using "implements"
> keyword.
> !image-2018-10-22-16-54-10-305.png!
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
