twalthr commented on a change in pull request #6897: [FLINK-9737] [FLINK-8880]
[sql-client] Support defining temporal tables in environment files
URL: https://github.com/apache/flink/pull/6897#discussion_r227255346
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
##########
@@ -185,6 +196,18 @@ class DescriptorProperties(normalizeKeys: Boolean = true)
{
putIndexedVariableProperties(key,
propertySets.asScala.map(_.asScala.toMap))
}
+ /**
+ * Adds an array of properties under a common key.
+ *
+ * The key consumer receives the array key and value for inserting the
array element.
+ */
+ def putArray[E](key: String, values: JList[E], keyConsumer:
BiConsumer[String, E]): Unit = {
Review comment:
Yes, you are right. This method was also one of the methods where I thought
it would make sense to make the `put/get/validate` methods more modular. I'm
fine with removing these changes for now and open a follow-up issue. The
temporal tables don't support composite keys so far anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
