kl0u commented on a change in pull request #6915: [FLINK-10663][streaming] Fix
NPE when StreamingFileSink is closed without initialization.
URL: https://github.com/apache/flink/pull/6915#discussion_r227746375
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -375,6 +375,8 @@ public void invoke(IN value, SinkFunction.Context context)
throws Exception {
@Override
public void close() throws Exception {
- buckets.close();
+ if (buckets != null) {
Review comment:
Here I would also add a comment to explain when this can be `null`. I know
it is covered by a test, but it is nice to also explain the why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
