GJL commented on a change in pull request #6915: [FLINK-10663][streaming] Fix
NPE when StreamingFileSink is closed without initialization.
URL: https://github.com/apache/flink/pull/6915#discussion_r227754363
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -375,6 +375,8 @@ public void invoke(IN value, SinkFunction.Context context)
throws Exception {
@Override
public void close() throws Exception {
- buckets.close();
+ if (buckets != null) {
Review comment:
`bucket` is non-final, and `Cmd + Alt + F7` shows there is only one
assignment in `initializeState()`. One reason why `buckets` can be `null` is
that `initializeState()` is not called at all. Another reason is that
`initializeState()` exits prematurely due to exceptions.
If there were more things to be closed, we would need more null checks, and
I would not add a comment to every null check. Hence, I would also not add a
comment when there is only a single null check. Imo a comment could be
perceived as too verbose because the necessity of the check is simple enough to
understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
