ifndef-SleePy commented on a change in pull request #6770: [FLINK-10002]
[Webfrontend] WebUI shows jm/tm logs more friendly.
URL: https://github.com/apache/flink/pull/6770#discussion_r228834637
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -814,14 +819,18 @@ public void heartbeatFromResourceManager(ResourceID
resourceID) {
}
@Override
- public CompletableFuture<TransientBlobKey> requestFileUpload(FileType
fileType, Time timeout) {
+ public CompletableFuture<TransientBlobKey> requestFileUpload(FileType
fileType, Time timeout, String filename, FileOffsetRange range) {
log.debug("Request file {} upload.", fileType);
final String filePath;
switch (fileType) {
case LOG:
- filePath =
taskManagerConfiguration.getTaskManagerLogPath();
+ if(filename != null && !filename.equals("")) {
Review comment:
```suggestion
if (filename != null && !filename.equals("")) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services