[ 
https://issues.apache.org/jira/browse/FLINK-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667086#comment-16667086
 ] 

ASF GitHub Bot commented on FLINK-7811:
---------------------------------------

aljoscha commented on a change in pull request #6894: [FLINK-7811] Add support 
for Scala 2.12
URL: https://github.com/apache/flink/pull/6894#discussion_r228899265
 
 

 ##########
 File path: tools/releasing/deploy_staging_jars.sh
 ##########
 @@ -40,6 +40,11 @@ cd ..
 
 echo "Deploying to repository.apache.org"
 
+COMMON_OPTIONS="-Prelease,docs-and-source -DskipTests 
-DretryFailedDeploymentCount=10"
+
 echo "Deploying Scala 2.11 version"
-$MVN clean deploy -Prelease,docs-and-source -DskipTests 
-DretryFailedDeploymentCount=10
+$MVN clean deploy $COMMON_OPTIONS -Pscala-2.11
 
 Review comment:
   I think using multiple `-P` flags works, I checked it with `mvn 
help:active-profiles -Pscala-2.12 -Pscala-11` (which is a stupid example but 
works).
   
   Nevertheless, I'll change to profile activation so that we can have a 
default profile. However, this will only work well as long as we only have two 
scala versions because I can use `!scala-2.12` and `scala-2.12`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add support for Scala 2.12
> --------------------------
>
>                 Key: FLINK-7811
>                 URL: https://issues.apache.org/jira/browse/FLINK-7811
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Scala API
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to