Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-132322001
Sorry to be picky again, but it would be good to harmonize the code style a
bit - make it more consistent with the remaining code.
What struck me in particular the omission of space before the curly braces
at the start of methods and other code blocks. All other parts of the code have
that.
There are ongoing discussions about making the code style stricter (also
with respect to white spaces), and this is much easier if new code follows this
standard already. Otherwise, there'd going to be a lot of style adjustments
necessary when introducing the check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
