aljoscha closed pull request #5871: [FLINK-9193] Deprecate non-well-defined
output methods on DataStream
URL: https://github.com/apache/flink/pull/5871
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
index 78ba8e4a5be..0d17612dd70 100644
---
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
+++
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
@@ -968,8 +968,11 @@ public ExecutionConfig getExecutionConfig() {
* The path pointing to the location the text file is
written to.
*
* @return The closed DataStream.
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to
files from a streaming program.
*/
@PublicEvolving
+ @Deprecated
public DataStreamSink<T> writeAsText(String path) {
return writeUsingOutputFormat(new TextOutputFormat<T>(new
Path(path)));
}
@@ -987,8 +990,11 @@ public ExecutionConfig getExecutionConfig() {
* NO_OVERWRITE and OVERWRITE.
*
* @return The closed DataStream.
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to
files from a streaming program.
*/
@PublicEvolving
+ @Deprecated
public DataStreamSink<T> writeAsText(String path, WriteMode writeMode) {
TextOutputFormat<T> tof = new TextOutputFormat<>(new
Path(path));
tof.setWriteMode(writeMode);
@@ -1006,8 +1012,11 @@ public ExecutionConfig getExecutionConfig() {
* the path pointing to the location the text file is
written to
*
* @return the closed DataStream
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to
files from a streaming program.
*/
@PublicEvolving
+ @Deprecated
public DataStreamSink<T> writeAsCsv(String path) {
return writeAsCsv(path, null,
CsvOutputFormat.DEFAULT_LINE_DELIMITER,
CsvOutputFormat.DEFAULT_FIELD_DELIMITER);
}
@@ -1026,8 +1035,11 @@ public ExecutionConfig getExecutionConfig() {
* NO_OVERWRITE and OVERWRITE.
*
* @return the closed DataStream
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to
files from a streaming program.
*/
@PublicEvolving
+ @Deprecated
public DataStreamSink<T> writeAsCsv(String path, WriteMode writeMode) {
return writeAsCsv(path, writeMode,
CsvOutputFormat.DEFAULT_LINE_DELIMITER,
CsvOutputFormat.DEFAULT_FIELD_DELIMITER);
}
@@ -1050,9 +1062,12 @@ public ExecutionConfig getExecutionConfig() {
* the delimiter for two fields
*
* @return the closed DataStream
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to
files from a streaming program.
*/
@SuppressWarnings("unchecked")
@PublicEvolving
+ @Deprecated
public <X extends Tuple> DataStreamSink<T> writeAsCsv(
String path,
WriteMode writeMode,
@@ -1085,8 +1100,11 @@ public ExecutionConfig getExecutionConfig() {
* @param schema
* schema for serialization
* @return the closed DataStream
+ *
+ * @deprecated Please use {@link #addSink(SinkFunction)} with {@link
SocketClientSink}.
*/
@PublicEvolving
+ @Deprecated
public DataStreamSink<T> writeToSocket(String hostName, int port,
SerializationSchema<T> schema) {
DataStreamSink<T> returnStream = addSink(new
SocketClientSink<>(hostName, port, schema, 0));
returnStream.setParallelism(1); // It would not work if
multiple instances would connect to the same port
@@ -1103,8 +1121,11 @@ public ExecutionConfig getExecutionConfig() {
*
* @param format The output format
* @return The closed DataStream
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to
files from a streaming program.
*/
@PublicEvolving
+ @Deprecated
public DataStreamSink<T> writeUsingOutputFormat(OutputFormat<T> format)
{
return addSink(new OutputFormatSinkFunction<>(format));
}
diff --git
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/OutputFormatSinkFunction.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/OutputFormatSinkFunction.java
index fbcc2d02d18..2bc47ef2614 100644
---
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/OutputFormatSinkFunction.java
+++
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/OutputFormatSinkFunction.java
@@ -37,8 +37,11 @@
* OutputFormat format.
*
* @param <IN> Input type
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to files from
a streaming program.
*/
@PublicEvolving
+@Deprecated
public class OutputFormatSinkFunction<IN> extends RichSinkFunction<IN>
implements InputTypeConfigurable {
private static final long serialVersionUID = 1L;
diff --git
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormat.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormat.java
index 65915af19da..6622ba55be5 100644
---
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormat.java
+++
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormat.java
@@ -28,8 +28,11 @@
*
* @param <IN>
* Input tuple type
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to files from
a streaming program.
*/
@PublicEvolving
+@Deprecated
public abstract class WriteFormat<IN> implements Serializable {
private static final long serialVersionUID = 1L;
diff --git
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormatAsCsv.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormatAsCsv.java
index 234dd39323f..8ac7a97f468 100644
---
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormatAsCsv.java
+++
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormatAsCsv.java
@@ -30,8 +30,11 @@
*
* @param <IN>
* Input tuple type
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to files from
a streaming program.
*/
@PublicEvolving
+@Deprecated
public class WriteFormatAsCsv<IN> extends WriteFormat<IN> {
private static final long serialVersionUID = 1L;
diff --git
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormatAsText.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormatAsText.java
index e331ed94d99..1c646623619 100644
---
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormatAsText.java
+++
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteFormatAsText.java
@@ -30,8 +30,11 @@
*
* @param <IN>
* Input tuple type
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to files from
a streaming program.
*/
@PublicEvolving
+@Deprecated
public class WriteFormatAsText<IN> extends WriteFormat<IN> {
private static final long serialVersionUID = 1L;
diff --git
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteSinkFunction.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteSinkFunction.java
index fa2bd8d1c26..efd15cb2eff 100644
---
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteSinkFunction.java
+++
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteSinkFunction.java
@@ -31,8 +31,11 @@
*
* @param <IN>
* Input tuple type
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to files from
a streaming program.
*/
@PublicEvolving
+@Deprecated
public abstract class WriteSinkFunction<IN> implements SinkFunction<IN> {
private static final long serialVersionUID = 1L;
diff --git
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteSinkFunctionByMillis.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteSinkFunctionByMillis.java
index 4753c5c1fa3..354b086c2de 100644
---
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteSinkFunctionByMillis.java
+++
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteSinkFunctionByMillis.java
@@ -25,8 +25,11 @@
*
* @param <IN>
* Input tuple type
+ *
+ * @deprecated Please use the {@code BucketingSink} for writing to files from
a streaming program.
*/
@PublicEvolving
+@Deprecated
public class WriteSinkFunctionByMillis<IN> extends WriteSinkFunction<IN> {
private static final long serialVersionUID = 1L;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
