tzulitai commented on a change in pull request #6959: [FLINK-10678][e2e] Introduced switch to disable log checking in e2e tests URL: https://github.com/apache/flink/pull/6959#discussion_r229943007
########## File path: flink-end-to-end-tests/run-nightly-tests.sh ########## @@ -41,19 +41,19 @@ echo "Flink distribution directory: $FLINK_DIR" # Template for adding a test: -# run_test "<description>" "$END_TO_END_DIR/test-scripts/<script_name>" +# run_test "<description>" "$END_TO_END_DIR/test-scripts/<script_name>" ["skip_check_exceptions"] Review comment: I think we should add at least comments about what the consequences are for skipping the exceptions check / in what situations you would want to skip exception checking completely. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
