pnowojski commented on a change in pull request #6987: [FLINK-8897] [table] Fix
rowtime materialization issues for filters and joins
URL: https://github.com/apache/flink/pull/6987#discussion_r230040369
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/validation/JoinValidationTest.scala
##########
@@ -136,4 +124,66 @@ class JoinValidationTest extends TableTestBase {
streamUtil.verifySql(sql, "n/a")
}
+
+ /** Rowtime attributes cannot be accessed in filter conditions yet. */
+ @Test(expected = classOf[TableException])
Review comment:
please add also some trivial expected message matcher, otherwise this can
give false negative results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services