[
https://issues.apache.org/jira/browse/FLINK-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther updated FLINK-10211:
---------------------------------
Description:
Currently
{{org.apache.flink.table.calcite.RelTimeIndicatorConverter#visit(LogicalJoin)}}
correctly handles only windowed joins. Output of non windowed joins shouldn't
contain any time indicators.
Update:
The root cause of this issue is the early phase in which
{{RelTimeIndicatorConverter}} is called. Due to lack of information (since the
join condition might not have been pushed into the join node), we can not
differentiate between a window and non-window join. Thus, we cannot perform the
time indicator materialization more fine grained. A solution would be to
perform the materialization later after the logical optimization and before the
physical translation, this would also make sense from a semantic perspective
because time indicators are more a physical characteristic.
was:
Currently
{{org.apache.flink.table.calcite.RelTimeIndicatorConverter#visit(LogicalJoin)}}
correctly handles only windowed joins. Output of non windowed joins shouldn't
contain any time indicators.
CC [~twalthr]
> Time indicators are not correctly materialized for LogicalJoin
> --------------------------------------------------------------
>
> Key: FLINK-10211
> URL: https://issues.apache.org/jira/browse/FLINK-10211
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.6.0
> Reporter: Piotr Nowojski
> Assignee: Timo Walther
> Priority: Major
>
> Currently
> {{org.apache.flink.table.calcite.RelTimeIndicatorConverter#visit(LogicalJoin)}}
> correctly handles only windowed joins. Output of non windowed joins
> shouldn't contain any time indicators.
> Update:
> The root cause of this issue is the early phase in which
> {{RelTimeIndicatorConverter}} is called. Due to lack of information (since
> the join condition might not have been pushed into the join node), we can not
> differentiate between a window and non-window join. Thus, we cannot perform
> the time indicator materialization more fine grained. A solution would be to
> perform the materialization later after the logical optimization and before
> the physical translation, this would also make sense from a semantic
> perspective because time indicators are more a physical characteristic.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
