[
https://issues.apache.org/jira/browse/FLINK-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672715#comment-16672715
]
ASF GitHub Bot commented on FLINK-10752:
----------------------------------------
dawidwys closed pull request #6991: [FLINK-10752][yarn] Use the validated
cluster resources in AbstractYarnClusterDescriptor
URL: https://github.com/apache/flink/pull/6991
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
b/flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
index c161e227577..198eab7ea81 100644
---
a/flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
+++
b/flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
@@ -111,12 +111,6 @@
public abstract class AbstractYarnClusterDescriptor implements
ClusterDescriptor<ApplicationId> {
private static final Logger LOG =
LoggerFactory.getLogger(AbstractYarnClusterDescriptor.class);
- /**
- * Minimum memory requirements, checked by the Client.
- */
- private static final int MIN_JM_MEMORY = 768; // the minimum memory
should be higher than the min heap cutoff
- private static final int MIN_TM_MEMORY = 768;
-
private final YarnConfiguration yarnConfiguration;
private final YarnClient yarnClient;
@@ -555,7 +549,7 @@ private void
validateClusterSpecification(ClusterSpecification clusterSpecificat
jobGraph,
yarnClient,
yarnApplication,
- clusterSpecification);
+ validClusterSpecification);
String host = report.getHost();
int port = report.getRpcPort();
@@ -570,8 +564,8 @@ private void
validateClusterSpecification(ClusterSpecification clusterSpecificat
// the Flink cluster is deployed in YARN. Represent cluster
return createYarnClusterClient(
this,
- clusterSpecification.getNumberTaskManagers(),
- clusterSpecification.getSlotsPerTaskManager(),
+ validClusterSpecification.getNumberTaskManagers(),
+ validClusterSpecification.getSlotsPerTaskManager(),
report,
flinkConfiguration,
true);
@@ -587,16 +581,6 @@ protected ClusterSpecification validateClusterResources(
int jobManagerMemoryMb =
clusterSpecification.getMasterMemoryMB();
int taskManagerMemoryMb =
clusterSpecification.getTaskManagerMemoryMB();
- if (jobManagerMemoryMb < MIN_JM_MEMORY) {
- LOG.warn("The minimum JobManager memory is {}. Will set
the JobManager memory to this value.", MIN_JM_MEMORY);
- jobManagerMemoryMb = MIN_JM_MEMORY;
- }
-
- if (taskManagerMemoryMb < MIN_TM_MEMORY) {
- LOG.warn("The minimum TaskManager memory is {}. Will
set the Taskmanager memory to this value.", MIN_TM_MEMORY);
- taskManagerMemoryMb = MIN_TM_MEMORY;
- }
-
if (jobManagerMemoryMb < yarnMinAllocationMB ||
taskManagerMemoryMb < yarnMinAllocationMB) {
LOG.warn("The JobManager or TaskManager memory is below
the smallest possible YARN Container size. "
+ "The value of
'yarn.scheduler.minimum-allocation-mb' is '" + yarnMinAllocationMB + "'. Please
increase the memory size." +
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Result of AbstractYarnClusterDescriptor#validateClusterResources is ignored
> ---------------------------------------------------------------------------
>
> Key: FLINK-10752
> URL: https://issues.apache.org/jira/browse/FLINK-10752
> Project: Flink
> Issue Type: Bug
> Components: YARN
> Reporter: Dawid Wysakowicz
> Assignee: Dawid Wysakowicz
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
