[
https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672849#comment-16672849
]
ASF GitHub Bot commented on FLINK-10715:
----------------------------------------
tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change
reporter log level
URL: https://github.com/apache/flink/pull/6996#discussion_r230312787
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -426,7 +426,12 @@ public void run() {
try {
reporter.report();
} catch (Throwable t) {
- LOG.warn("Error while reporting metrics", t);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Error while reporting
metrics {}", t);
+ }
+ else {
+ LOG.warn("Error while reporting
metrics", t.getMessage());
Review comment:
I would actually log this on `info` level since warnings and errors should
indicate a Flink problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> E2e tests fail with ConcurrentModificationException in MetricRegistryImpl
> -------------------------------------------------------------------------
>
> Key: FLINK-10715
> URL: https://issues.apache.org/jira/browse/FLINK-10715
> Project: Flink
> Issue Type: Bug
> Components: E2E Tests, Metrics
> Affects Versions: 1.7.0
> Reporter: Dawid Wysakowicz
> Assignee: Igal Shilman
> Priority: Blocker
> Labels: pull-request-available
>
> Couple of e2e tests that rely on metrics fail with exception:
> {code}
> 2018-10-29 11:40:32,781 WARN
> org.apache.flink.runtime.metrics.MetricRegistryImpl - Error while
> reporting metrics
> java.util.ConcurrentModificationException
> at java.util.HashMap$HashIterator.nextNode(HashMap.java:1437)
> at java.util.HashMap$EntryIterator.next(HashMap.java:1471)
> at java.util.HashMap$EntryIterator.next(HashMap.java:1469)
> at
> org.apache.flink.metrics.slf4j.Slf4jReporter.report(Slf4jReporter.java:101)
> at
> org.apache.flink.runtime.metrics.MetricRegistryImpl$ReporterTask.run(MetricRegistryImpl.java:427)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> Tests that failed:
> * 'Resuming Externalized Checkpoint (file, sync, no parallelism change)
> end-to-end test
> * 'State TTL Heap backend end-to-end test'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
