tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change
reporter log level
URL: https://github.com/apache/flink/pull/6996#discussion_r230332712
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -426,7 +426,12 @@ public void run() {
try {
reporter.report();
} catch (Throwable t) {
- LOG.warn("Error while reporting metrics", t);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Error while reporting
metrics {}", t);
+ }
+ else {
+ LOG.warn("Error while reporting
metrics", t.getMessage());
Review comment:
We could also keep it as a warning. I'm just wondering whether we should log
the stack traces of an exception where we know that some of these exceptions
are actually caused by us and are not critical. This will make people wary even
though there is nothing to be concerned about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
