uce opened a new pull request #7004: [FLINK-10743] [runtime] Use 0 processExitCode for ApplicationStatus.CANCELED URL: https://github.com/apache/flink/pull/7004 ## What is the purpose of the change This pull request changes the process exit code of `ApplicationStatus.CANCELED` to `0`. This handles cancellation as successful termination since it is triggered by a user. We map the Flink internal `JobStatus` to `ApplicationStatus` and use the attached exit code to terminate the entry point. ## Brief change log - Change `processExitCode` to `0` of `ApplicationStatus.CANCELED` - Add test for successful vs. non-successful ApplicationStatus exit codes ## Verifying this change - You can verify this change by running the `StandaloneJobClusterEntryPoint` in Kubernetes as documented in [flink-container](https://github.com/apache/flink/tree/master/flink-container/kubernetes). Before this change, cancellation leads to immediate restart of the job. With this fix, the job terminates properly. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: Potentially **yes**. Other cluster frameworks might still expect the non-zero exit code. The tests don't cover this. Therefore, I'm assuming that it does not effect them. - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
