[
https://issues.apache.org/jira/browse/FLINK-10747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672917#comment-16672917
]
ASF GitHub Bot commented on FLINK-10747:
----------------------------------------
NicoK commented on a change in pull request #6992: [FLINK-10747] Update
SingleInputGate#requestedPartitionsFlag under lock
URL: https://github.com/apache/flink/pull/6992#discussion_r230332580
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -482,23 +482,25 @@ public void requestPartitions() throws IOException,
InterruptedException {
}
synchronized (requestLock) {
- if (isReleased) {
- throw new IllegalStateException("Already
released.");
- }
+ if (!requestedPartitionsFlag) {
Review comment:
we should follow the same "having the shorter/simpler branch first" approach
as before (also see
https://github.com/apache/flink/pull/6974#discussion_r229666072 )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CoGroupConnectedComponentsITCase deadlocked on Travis
> -----------------------------------------------------
>
> Key: FLINK-10747
> URL: https://issues.apache.org/jira/browse/FLINK-10747
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: pull-request-available, test-stability
> Fix For: 1.7.0
>
>
> The {{CoGroupConnectedComponentsITCase}} deadlocks on Travis:
> https://api.travis-ci.org/v3/job/449230962/log.txt.
> It looks as if the iteration gets stuck and waits
> {{SuperstepKickoffLatch.awaitStartOfSuperstepOrTermination}} without ever
> getting a proper notification. This might indicate a serious bug in our
> iteration implementation. This could also be related to FLINK-10741.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
