[
https://issues.apache.org/jira/browse/FLINK-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673241#comment-16673241
]
ASF GitHub Bot commented on FLINK-10633:
----------------------------------------
kl0u commented on a change in pull request #7003: [FLINK-10633][prometheus] Add
E2E test
URL: https://github.com/apache/flink/pull/7003#discussion_r230403162
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/CommandLineWrapper.java
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util;
+
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Utility class for setting up command-line tool usages in a readable fashion.
+ */
+public enum CommandLineWrapper {
+ ;
+
+ public static WGetBuilder wget(String url) {
+ return new WGetBuilder(url);
+ }
+
+ /**
+ * Wrapper around wget used for downloading files.
+ */
+ public static final class WGetBuilder {
+
+ private final String url;
+ private Path targetDir;
+
+ WGetBuilder(String url) {
+ this.url = url;
+ }
+
+ public WGetBuilder targetDir(Path dir) {
+ this.targetDir = dir;
+ return this;
+ }
+
+ public String[] build() {
+ final List<String> commandsList = new ArrayList<>(5);
+ commandsList.add("wget");
+ commandsList.add("-q"); // silent
+ //commandsList.add("--show-progress"); // enable
progress bar
+ if (targetDir != null) {
+ commandsList.add("-P");
+
commandsList.add(targetDir.toAbsolutePath().toString());
+ }
+ commandsList.add(url);
+ return commandsList.toArray(new
String[commandsList.size()]);
+ }
+ }
+
+ public static SedBuilder sed(final String command, final Path file) {
+ return new SedBuilder(command, file);
+ }
+
+ /**
+ * Wrapper around sed used for processing text.
+ */
+ public static final class SedBuilder {
+
+ private final String command;
+ private final Path file;
+
+ private boolean inPlace = false;
+
+ SedBuilder(final String command, final Path file) {
+ this.command = command;
+ this.file = file;
+ }
+
+ public SedBuilder inPlace() {
+ inPlace = true;
Review comment:
Same here as in the `WGetBuilder`. Why not imposing immutability and go for
the "full" builder pattern?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> End-to-end test: Prometheus reporter
> ------------------------------------
>
> Key: FLINK-10633
> URL: https://issues.apache.org/jira/browse/FLINK-10633
> Project: Flink
> Issue Type: Sub-task
> Components: E2E Tests
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Add an end-to-end test using the {{PrometheusReporter}} to verify that all
> metrics are properly reported. Additionally verify that the newly introduce
> RocksDB metrics are accessible (see FLINK-10423).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
