NicoK commented on a change in pull request #6705: [FLINK-10356][network] add
sanity checks to SpillingAdaptiveSpanningRecordDeserializer
URL: https://github.com/apache/flink/pull/6705#discussion_r230420404
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializationTest.java
##########
@@ -104,11 +120,236 @@ public void testHandleMixedLargeRecords() throws
Exception {
testSerializationRoundTrip(originalRecords, segmentSize);
}
+ /**
+ * Non-spanning, deserialization reads one byte too many and succeeds.
+ */
+ @Test
+ public void testHandleDeserializingTooMuchNonSpanning1() throws
Exception {
+ testHandleWrongDeserialization(
+ new StringValueDeserializingTooMuch("Test string"),
+ 32 * 1024,
+ null);
+ }
+
+ /**
+ * Non-spanning, serialization length is 16 (including headers),
deserialization reads one byte
+ * too many and succeeds.
+ */
+ @Test
+ public void testHandleDeserializingTooMuchNonSpanning2() throws
Exception {
+ testHandleWrongDeserialization(
+ new StringValueDeserializingTooMuch("Test string"),
+ 17,
Review comment:
yes, that would be really nice but is not available out of the box since
`StringValue#getBinaryLength` only returns `-1` and additionally, we do add one
more length header from the `SpanningRecordSerializer` - I could evaluate the
actual value through serializing it (maybe only once, statically) though and
keep using that or so...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
