fhueske commented on issue #7012: [FLINK-10769][Table & SQL] port InMemoryExternalCatalog to java URL: https://github.com/apache/flink/pull/7012#issuecomment-435840758 Thanks for the PR @bowenli86. I haven't had a detailed look at the PR yet (will try to do in the next days). Just one side note. I don't think there we have consensus on porting all code of the `flink-table` module to Java. In fact, I'd really like to avoid a fragmented code base. Instead, I'm in favor of splitting the module into modules (for example `flink-table-runtime`, `flink-table-planning`, `flink-table-api`) that can be incrementally ported to Java. This should be fairly easy for `flink-table-runtime` and hopefully possible for `flink-table-planning`. `flink-table-api` will be very challenging (if not impossible). So, before porting more Scala code to Java, we should reach consensus about our plans. There should be a thread on the dev mailing list that started exactly this discussion. Thanks, Fabian
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
