[
https://issues.apache.org/jira/browse/FLINK-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674993#comment-16674993
]
ASF GitHub Bot commented on FLINK-10769:
----------------------------------------
fhueske commented on issue #7012: [FLINK-10769][Table & SQL] port
InMemoryExternalCatalog to java
URL: https://github.com/apache/flink/pull/7012#issuecomment-435840758
Thanks for the PR @bowenli86. I haven't had a detailed look at the PR yet
(will try to do in the next days).
Just one side note. I don't think there we have consensus on porting all
code of the `flink-table` module to Java. In fact, I'd really like to avoid a
fragmented code base. Instead, I'm in favor of splitting the module into
modules (for example `flink-table-runtime`, `flink-table-planning`,
`flink-table-api`) that can be incrementally ported to Java. This should be
fairly easy for `flink-table-runtime` and hopefully possible for
`flink-table-planning`. `flink-table-api` will be very challenging (if not
impossible). So, before porting more Scala code to Java, we should reach
consensus about our plans. There should be a thread on the dev mailing list
that started exactly this discussion.
Thanks, Fabian
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> port InMemoryExternalCatalog to java
> ------------------------------------
>
> Key: FLINK-10769
> URL: https://issues.apache.org/jira/browse/FLINK-10769
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Bowen Li
> Assignee: Bowen Li
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> In the Flink-Hive integration design, we propose a new FlinkInMemoryCatalog
> (FLINK-10697) for production use. FlinkInMemoryCatalog will share some part
> with the existing InMemoryExternalCatalog, thus we need to make changes to
> InMemoryExternalCatalog.
> As we are moving away from Scala to Java, we should write all new
> code/feature in Java. Therefore, we will port InMemoryExternalCatalog to java
> first without any feature or behavior change.
> This is a pre-requisite for FLINK-10697
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
