[
https://issues.apache.org/jira/browse/FLINK-10793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675159#comment-16675159
]
ASF GitHub Bot commented on FLINK-10793:
----------------------------------------
asfgit closed pull request #7021: [FLINK-10793][ttl] Change visibility of
TtlValue and TtlSerializer to…
URL: https://github.com/apache/flink/pull/7021
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
index 45f4e3bf143..0a881c70978 100644
---
a/flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
+++
b/flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
@@ -188,15 +188,17 @@ private IS createReducingState() throws Exception {
}
}
- /** Serializer for user state value with TTL. */
- private static class TtlSerializer<T> extends
CompositeSerializer<TtlValue<T>> {
+ /**
+ * Serializer for user state value with TTL. Visibility is public for
usage with external tools.
+ */
+ public static class TtlSerializer<T> extends
CompositeSerializer<TtlValue<T>> {
private static final long serialVersionUID =
131020282727167064L;
- TtlSerializer(TypeSerializer<T> userValueSerializer) {
+ public TtlSerializer(TypeSerializer<T> userValueSerializer) {
super(true, LongSerializer.INSTANCE,
userValueSerializer);
}
- TtlSerializer(PrecomputedParameters precomputed,
TypeSerializer<?> ... fieldSerializers) {
+ public TtlSerializer(PrecomputedParameters precomputed,
TypeSerializer<?> ... fieldSerializers) {
super(precomputed, fieldSerializers);
}
diff --git
a/flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlValue.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlValue.java
index 48435d567e8..dba06d3a88b 100644
---
a/flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlValue.java
+++
b/flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlValue.java
@@ -23,28 +23,28 @@
import java.io.Serializable;
/**
- * This class wraps user value of state with TTL.
+ * This class wraps user value of state with TTL. Visibility is public for
usage with external tools.
*
* @param <T> Type of the user value of state with TTL
*/
-class TtlValue<T> implements Serializable {
+public class TtlValue<T> implements Serializable {
private static final long serialVersionUID = 5221129704201125020L;
@Nullable
private final T userValue;
private final long lastAccessTimestamp;
- TtlValue(@Nullable T userValue, long lastAccessTimestamp) {
+ public TtlValue(@Nullable T userValue, long lastAccessTimestamp) {
this.userValue = userValue;
this.lastAccessTimestamp = lastAccessTimestamp;
}
@Nullable
- T getUserValue() {
+ public T getUserValue() {
return userValue;
}
- long getLastAccessTimestamp() {
+ public long getLastAccessTimestamp() {
return lastAccessTimestamp;
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Change visibility of TtlValue and TtlSerializer to public for external tools
> ----------------------------------------------------------------------------
>
> Key: FLINK-10793
> URL: https://issues.apache.org/jira/browse/FLINK-10793
> Project: Flink
> Issue Type: Wish
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.2, 1.7.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Major
> Labels: pull-request-available
>
> We should change the visibility of TtlValue and TtlSerializer to public so
> that external (savepoint) tools like Bravo can use them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
