yanghua commented on a change in pull request #6963: [FLINK-10704] Fix sql client end to end test failure URL: https://github.com/apache/flink/pull/6963#discussion_r230758661
########## File path: flink-end-to-end-tests/run-pre-commit-tests.sh ########## @@ -48,6 +48,7 @@ echo "Flink distribution directory: $FLINK_DIR" # those checks are disabled, one should take care that a proper checks are performed in the tests itself that ensure that the test finished # in an expected state. +run_test "SQL Client end-to-end test" "$END_TO_END_DIR/test-scripts/test_sql_client.sh" "skip_check_exceptions" Review comment: On this point, I think a more reasonable approach is that we can add ignore list or whitelist to the global check method, which may be more scalable. I think this change should be universal and the refactoring should be independent of any specific test. And I saw some tests that skipped the error detection and did not add custom detection. So I chose to skip detection temporarily and reconstruct the global detection method on an independent PR. Finally, we can add this special log to ignore list. What do you think of this idea? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
