pnowojski commented on a change in pull request #6963: [FLINK-10704] Fix sql client end to end test failure URL: https://github.com/apache/flink/pull/6963#discussion_r230793009
########## File path: flink-end-to-end-tests/run-pre-commit-tests.sh ########## @@ -48,6 +48,7 @@ echo "Flink distribution directory: $FLINK_DIR" # those checks are disabled, one should take care that a proper checks are performed in the tests itself that ensure that the test finished # in an expected state. +run_test "SQL Client end-to-end test" "$END_TO_END_DIR/test-scripts/test_sql_client.sh" "skip_check_exceptions" Review comment: Please add `Error while loading kafka-version.properties :null` to global ignore list in this PR, to make it fully complete and working. If you want to clean it up later, by moving this `Error while loading kafka-version.properties :null` from global ignore list to a local ignore list, it can be done in separate PR/issue. Merging this with completely disabled exceptions checking is asking for troubles. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
