[ 
https://issues.apache.org/jira/browse/FLINK-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676493#comment-16676493
 ] 

ASF GitHub Bot commented on FLINK-7155:
---------------------------------------

rmetzger commented on issue #6976: [FLINK-7155][metrics] Add new metrics 
reporter to InfluxDB
URL: https://github.com/apache/flink/pull/6976#issuecomment-436199529
 
 
   Thank you for the pull request.
   One thing I'd like to discuss is the behavior regarding automatic database 
creation. From the code, it seems that there is no special handling for the 
case when the database the user configured doesn't exist.
   Will the influxdb client just throw an exception if the db doesn't exist?
   Does it make sense to consider automatically creating the db if it doesn't 
exist?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add Influxdb metrics reporter
> -----------------------------
>
>                 Key: FLINK-7155
>                 URL: https://issues.apache.org/jira/browse/FLINK-7155
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: Patrick Lucas
>            Assignee: Patrick Lucas
>            Priority: Major
>              Labels: pull-request-available
>
> [~jgrier] has a [simple Influxdb metrics reporter for 
> Flink|https://github.com/jgrier/flink-stuff/tree/master/flink-influx-reporter]
>  that is a thing wrapper around [a lightweight, public-domain Influxdb 
> reporter|https://github.com/davidB/metrics-influxdb] for Codahale metrics.
> We can implement this very easily in Java in the same as as 
> flink-metrics-graphite.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to