zhijiangW commented on a change in pull request #7031:
[FLINK-10800][network][test] Abstract StreamPartitionerTest for common codes
URL: https://github.com/apache/flink/pull/7031#discussion_r231067080
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/partitioner/ForwardPartitionerTest.java
##########
@@ -29,31 +25,19 @@
/**
* Tests for {@link ForwardPartitioner}.
*/
-public class ForwardPartitionerTest {
-
- private ForwardPartitioner<Tuple> forwardPartitioner;
- private StreamRecord<Tuple> streamRecord = new
StreamRecord<Tuple>(null);
- private SerializationDelegate<StreamRecord<Tuple>> sd = new
SerializationDelegate<StreamRecord<Tuple>>(
- null);
+public class ForwardPartitionerTest extends StreamPartitionerTest {
@Before
public void setPartitioner() {
- forwardPartitioner = new ForwardPartitioner<Tuple>();
- }
-
- @Test
- public void testSelectChannelsLength() {
- sd.setInstance(streamRecord);
- assertEquals(1, forwardPartitioner.selectChannels(sd,
1).length);
- assertEquals(1, forwardPartitioner.selectChannels(sd,
2).length);
- assertEquals(1, forwardPartitioner.selectChannels(sd,
1024).length);
+ streamPartitioner = new ForwardPartitioner<>();
}
@Test
public void testSelectChannelsInterval() {
sd.setInstance(streamRecord);
- assertEquals(0, forwardPartitioner.selectChannels(sd, 1)[0]);
- assertEquals(0, forwardPartitioner.selectChannels(sd, 2)[0]);
- assertEquals(0, forwardPartitioner.selectChannels(sd, 1024)[0]);
+
+ assertEquals(0, streamPartitioner.selectChannels(sd, 1)[0]);
Review comment:
This define could not be reused directly by `ShufflePartitionerTest` and
`RebalancePartitionerTest`. And it will not reduce the code lines totally for
reuse ones. So I think it is not very worth doing. What do you think or you
have other concerns of this define?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
