[
https://issues.apache.org/jira/browse/FLINK-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677646#comment-16677646
]
ASF GitHub Bot commented on FLINK-10790:
----------------------------------------
zhijiangW commented on issue #7037: [FLINK-10790][network] Refactor
StreamPartitioner implementations into runtime module
URL: https://github.com/apache/flink/pull/7037#issuecomment-436496303
@pnowojski , this is the preparation for unifying implementations in both
stream and batch modes. As I described in above purpose, I would submit the
following PRs for de-duplication if you think this module refactor make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor all the StreamPartitioner implementations into runtime module
> ----------------------------------------------------------------------
>
> Key: FLINK-10790
> URL: https://issues.apache.org/jira/browse/FLINK-10790
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.8.0
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
>
> The motivation is for refactoring {{ChannelSelector}} interface mentioned in
> [FLINK-10662|https://issues.apache.org/jira/browse/FLINK-10662].
> The {{ChannelSelector}} implementations are separate for stream and batch
> currently, resulting in many duplicated logics for selecting channels. The
> root cause is that they are locating in different modules to not reuse the
> existing ones.
> In general, the core runtime codes should be unified for both stream and
> batch jobs as much as possible, then we can reduce the work overhead to
> maintain the duplicated codes.
> This jira would migrate the existing partitioner package from
> {{flink-streaming-jave}} to {{flink-runtime}}. Next we want to de-duplicate
> implementations for {{RoundRobinChannelSelector}} and {{OutputEmitter}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
