[
https://issues.apache.org/jira/browse/FLINK-10789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677657#comment-16677657
]
ASF GitHub Bot commented on FLINK-10789:
----------------------------------------
tzulitai commented on issue #7028: [FLINK-10789] New serializer snapshots after
1.6 should implement TypeSerializerSnapshot
URL: https://github.com/apache/flink/pull/7028#issuecomment-436501351
Thanks for the review @StefanRRichter!
Will proceed to merge this and also the 1.7 backport.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Some new serializer snapshots added after 1.6 are not implementing the new
> TypeSerializerSnapshot interface
> -----------------------------------------------------------------------------------------------------------
>
> Key: FLINK-10789
> URL: https://issues.apache.org/jira/browse/FLINK-10789
> Project: Flink
> Issue Type: Improvement
> Components: Type Serialization System
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Critical
> Labels: pull-request-available
>
> In commit
> [3787b89105c6a005ddca999b0b8a0356e812ede6|[https://github.com/apache/flink/commit/3787b89105c6a005ddca999b0b8a0356e812ede6],]
> there were a few serializer snapshot implementations that were newly added,
> namely:
> - {{LockableSerializerConfigSnapshot}}
> - {{ListViewSerializerConfigSnapshot}}
> - {{MapViewSerializerConfigSnapshot}}
> - {{ScalaEitherSerializerConfigSnapshot}}
> The problem is that instead of implementing the newer
> {{TypeSerializerSnapshot}}, they are extending the legacy deprecated
> {{TypeSerializerConfigSnapshot}}. This doesn't break things, but we will be
> redundantly writing Java-serialized with the new snapshots, as well as
> causing us to must introduce migration paths code later on after releasing
> them.
> It would be more ideal to implement them properly as
> {{TypeSerializerSnapshot}} for the release.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
