jrthe42 commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly. URL: https://github.com/apache/flink/pull/7014#issuecomment-436570733 Hi @Xpray, I only add a test case for **NonWindowJoin**, that is what we meet in our application. I will try to add more test cases later. Even if some generated functions do not have UDF inside, I think it is still better if we call *open* and *close* method explicitly. We can cover the full lifecycle of generated functions in this way. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
