tillrohrmann commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests URL: https://github.com/apache/flink/pull/7034#discussion_r231456626
########## File path: flink-end-to-end-tests/test-scripts/test_sql_client.sh ########## @@ -360,13 +362,14 @@ check_result_hash "SQL Client Kafka" $RESULT "0a1bf8bf716069b7269f575f87a802c0" echo "Executing SQL: Values -> Elasticsearch (upsert)" -read -r -d '' SQL_STATEMENT_3 << EOF Review comment: It's not a cleanup. `read` always terminates with a non-zero exit code if it sees `EOF`. It's better to simply use `cat` and this will fix this test to work with the `set -e` command. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
