[ 
https://issues.apache.org/jira/browse/FLINK-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678352#comment-16678352
 ] 

Chesnay Schepler commented on FLINK-10813:
------------------------------------------

Not as simple unfortunately. Basically what the script does is search the 
transitive dependencies of every module for {{scala.lang}}, and if found 
ensures that it has a suffix.

It does not account or the scope however and rejects multiple modules (like 
flink-metrics-dropwizard. It also doesn't care about provided/optional 
dependencies. WIll have to spend some extra time on this.

[~aljoscha] Is it correct to say that "A module needs a scala-suffix if it 
contains scala-code and/or has a compile/runtime (i.e. transitive) dependency 
on an artifact with a scala-suffix?"

> Automatically seach for missing scala suffixes
> ----------------------------------------------
>
>                 Key: FLINK-10813
>                 URL: https://issues.apache.org/jira/browse/FLINK-10813
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.8.0
>
>
> To ensure issues like FLINK-10811 cannot pop up again we should look into 
> automating the scala-suffix requirements check.
> We already have a script to do this check (tools/verify_scala_suffixes.sh), 
> supposedly we just have to add it to travis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to