[
https://issues.apache.org/jira/browse/FLINK-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678375#comment-16678375
]
ASF GitHub Bot commented on FLINK-10676:
----------------------------------------
sunjincheng121 commented on a change in pull request #6949:
[FLINK-10676][table] Add 'as' method for OverWindowWithOrderBy
URL: https://github.com/apache/flink/pull/6949#discussion_r231493947
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/windows.scala
##########
@@ -18,7 +18,8 @@
package org.apache.flink.table.api.java
-import org.apache.flink.table.api.{TumbleWithSize, OverWindowWithPreceding,
SlideWithSize, SessionWithGap}
+import org.apache.flink.table.api.scala.{CURRENT_RANGE, UNBOUNDED_RANGE}
+import org.apache.flink.table.api._
Review comment:
I think using `import org.apache.flink.table.api.{OverWindow,
TumbleWithSize, OverWindowWithPreceding, SlideWithSize, SessionWithGap}
` is better than using wildcard, because there are not many classes imported
here.What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add 'as' method for OverWindowWithOrderBy in Java API
> -----------------------------------------------------
>
> Key: FLINK-10676
> URL: https://issues.apache.org/jira/browse/FLINK-10676
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.7.0
> Reporter: sunjincheng
> Assignee: Hequn Cheng
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> The preceding clause of OVER Window in the traditional database is optional.
> The default is UNBOUNDED. So we can add the "as" method to
> OverWindowWithOrderBy. This way OVERWindow is written more easily. e.g.:
> {code:java}
> .window(Over partitionBy 'c orderBy 'proctime preceding UNBOUNDED_ROW as
> 'w){code}
> Can be simplified as follows:
> {code:java}
> .window(Over partitionBy 'c orderBy 'proctime as 'w){code}
> What do you think?
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
