[
https://issues.apache.org/jira/browse/FLINK-9001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679684#comment-16679684
]
ASF GitHub Bot commented on FLINK-9001:
---------------------------------------
twalthr commented on a change in pull request #7042: [FLINK-9001] [e2e] Add
operators with input type that goes through Kryo serialization
URL: https://github.com/apache/flink/pull/7042#discussion_r231868105
##########
File path:
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/DataStreamAllroundTestProgram.java
##########
@@ -172,6 +179,30 @@ public void apply(Integer integer, TimeWindow window,
Iterable<Event> input, Col
in -> (Integer) in.get("key"),
"Avro (Generic)");
+ // test operator input serialization that goes through Kryo,
without the type registered
+ eventStream3 = testSpecificOperatorInputTypeSerialization(
+ eventStream3,
+ in -> new GenericKryoEvent(in.getKey(),
in.getEventTime(), in.getSequenceNumber(), in.getPayload()),
+ in -> new Event(in.getKey(), in.getEventTime(),
in.getSequenceNumber(), in.getPayload()),
+ GenericKryoEvent::getKey,
+ "Kryo (Generic)");
Review comment:
Should we also pass the expected serializer class to this method or some
validation lambda that takes the serializer such that we can perform some
validation to make sure we are testing the right thing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add operators with input type that goes through Kryo serialization
> (registered/generic/custom)
> -----------------------------------------------------------------------------------------------
>
> Key: FLINK-9001
> URL: https://issues.apache.org/jira/browse/FLINK-9001
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Stefan Richter
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
