[ 
https://issues.apache.org/jira/browse/FLINK-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679597#comment-16679597
 ] 

ASF GitHub Bot commented on FLINK-10531:
----------------------------------------

StefanRRichter commented on issue #7036: [FLINK-10531][e2e] Fix unstable TTL 
end-to-end test.
URL: https://github.com/apache/flink/pull/7036#issuecomment-436954874
 
 
   I wonder if it would not make more sense to use a monotonous time provider 
for a single machine, such as `System.nanoTime()`, or a wrapper around time 
millis that prevents falling back in time, or some test implementation that the 
test can control, for the test instead of ignoring elements and potentially 
missing out on errors. `TtlTimeProvider` is already an interface, and 
`TtlTimeProvider DEFAULT = System::currentTimeMillis;` is used in all places. 
Instead this could be the first case where we want to make the time provider 
configurable via a factor. The simplest case could just replace it when 
encountering a certain config entry or property. 
   
   Another option would be that if we detect such time changes we exit the test 
with a certain exit code and rerun it again. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> State TTL RocksDb backend end-to-end test failed on Travis
> ----------------------------------------------------------
>
>                 Key: FLINK-10531
>                 URL: https://issues.apache.org/jira/browse/FLINK-10531
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.6.1
>            Reporter: Till Rohrmann
>            Assignee: Kostas Kloudas
>            Priority: Critical
>              Labels: pull-request-available, test-stability
>             Fix For: 1.7.0
>
>
> The {{State TTL RocksDb backend end-to-end test}} end-to-end test failed on 
> Travis.
> https://travis-ci.org/apache/flink/jobs/438226190
> https://api.travis-ci.org/v3/job/438226190/log.txt



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to