[
https://issues.apache.org/jira/browse/FLINK-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679455#comment-16679455
]
ASF GitHub Bot commented on FLINK-10816:
----------------------------------------
StefanRRichter commented on a change in pull request #7049: [FLINK-10816][cep]
Fix LockableTypeSerializer.duplicate() to consider…
URL: https://github.com/apache/flink/pull/7049#discussion_r231804087
##########
File path:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/Lockable.java
##########
@@ -109,8 +110,10 @@ public boolean isImmutableType() {
}
@Override
- public TypeSerializer<Lockable<E>> duplicate() {
- return new LockableTypeSerializer<>(elementSerializer);
+ public LockableTypeSerializer<E> duplicate() {
Review comment:
Because some code might want to get a `LockableTypeSerializer` when
duplicating a `LockableTypeSerializer` and that also only happens when you
already have a hold on a `LockableTypeSerializer` otherwise the interface will
still give you the general type. A more practical example, the test required
this to access the `getElementSerializer()` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix LockableTypeSerializer.duplicate()
> ---------------------------------------
>
> Key: FLINK-10816
> URL: https://issues.apache.org/jira/browse/FLINK-10816
> Project: Flink
> Issue Type: Bug
> Components: CEP
> Affects Versions: 1.6.2, 1.7.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Major
> Labels: pull-request-available
>
> {{LockableTypeSerializer.duplicate()}} is not properly implemented and must
> consider duplicating the element serializer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
