[
https://issues.apache.org/jira/browse/FLINK-8997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679619#comment-16679619
]
ASF GitHub Bot commented on FLINK-8997:
---------------------------------------
kl0u commented on a change in pull request #7039: [FLINK-8997] Added sliding
window aggregation to datastream test job
URL: https://github.com/apache/flink/pull/7039#discussion_r231845864
##########
File path:
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/DataStreamAllroundTestJobFactory.java
##########
@@ -86,6 +88,8 @@
* <li>sequence_generator_source.event_time.clock_progress (long, default
- 100): The amount of event time to progress per event generated by the
sequence generator.</li>
* <li>tumbling_window_operator.num_events (long, default - 20L): The
duration of the window, indirectly determined by the target number of events in
each window.
* Total duration is (sliding_window_operator.num_events) *
(sequence_generator_source.event_time.clock_progress).</li>
+ * <li>test_slide_factor (int, default - 3): how many slides there are in
a single window (in other words at most how many windows may be opened at
time</li>
Review comment:
`test_slide_factor (int, default - 3): how many slides there are in a single
window (in other words at most how many windows may be opened at time` ->
`test_slide_factor (int, default - 3): how many slides there are in a single
window (in other words at most how many windows may be opened at time for a
given key)`
Also it makes sense to explain the relationship between the `size` and the
`factor`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add sliding window aggregation to the job
> -----------------------------------------
>
> Key: FLINK-8997
> URL: https://issues.apache.org/jira/browse/FLINK-8997
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Stefan Richter
> Assignee: Dawid Wysakowicz
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> The test job should also test windowing. Sliding windows are probably the
> most demanding form, so this would be a good pick for the test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
