[
https://issues.apache.org/jira/browse/FLINK-10827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682633#comment-16682633
]
ASF GitHub Bot commented on FLINK-10827:
----------------------------------------
tillrohrmann commented on a change in pull request #7061: [FLINK-10827][tests]
Add test for duplicate() to SerializerTestBase
URL: https://github.com/apache/flink/pull/7061#discussion_r232467694
##########
File path:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestBase.java
##########
@@ -526,6 +561,55 @@ public void write(DataInputView source, int numBytes)
throws IOException {
}
}
+ /**
+ * Runner to test serializer duplication via concurrency.
+ * @param <T> type of the test elements.
+ */
+ static class SerializerRunner<T> extends Thread {
+ final OneShotLatch startLatch;
+ final TypeSerializer<T> serializer;
+ final T[] testData;
+ final int iterations;
+ Exception failure;
+
+ SerializerRunner(OneShotLatch startLatch, TypeSerializer<T>
serializer, T[] testData, int iterations) {
+ this.startLatch = startLatch;
+ this.serializer = serializer;
+ this.testData = testData;
+ this.iterations = iterations;
+ this.failure = null;
+ }
+
+ @Override
+ public void run() {
+ DataInputDeserializer dataInputDeserializer = new
DataInputDeserializer();
+ DataOutputSerializer dataOutputSerializer = new
DataOutputSerializer(128);
+ try {
+ startLatch.await();
+ for (int repeat = 0; repeat < iterations;
++repeat) {
+ for (T testItem : testData) {
+ serializer.serialize(testItem,
dataOutputSerializer);
+ dataInputDeserializer.setBuffer(
+
dataOutputSerializer.getSharedBuffer(),
+ 0,
+
dataOutputSerializer.length());
+ T serdeTestItem =
serializer.deserialize(dataInputDeserializer);
+ T copySerdeTestItem =
serializer.copy(serdeTestItem);
+ dataOutputSerializer.clear();
+ Assert.assertEquals(testItem,
copySerdeTestItem);
+ }
+ }
+ } catch (Exception ex) {
Review comment:
I guess we should catch all `Throwables` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add test for duplicate() to SerializerTestBase
> ----------------------------------------------
>
> Key: FLINK-10827
> URL: https://issues.apache.org/jira/browse/FLINK-10827
> Project: Flink
> Issue Type: Test
> Components: Tests
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> In the past, we had many bugs from type serializers that have not properly
> implemented the {{duplicate()}} method in a proper way. A very common error
> is to forget about creating a deep copy of some fields that can lead to
> concurrency problems in the backend.
> We should add a test case for that tests duplicated serializer from different
> threads to expose concurrency problems.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
