tillrohrmann commented on a change in pull request #7064: [FLINK-10753] Improve
propagation and logging of snapshot exceptions
URL: https://github.com/apache/flink/pull/7064#discussion_r232468462
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -433,25 +434,26 @@ public void abortSubsumed() {
}
}
+
public void abortDeclined() {
- try {
- Exception cause = new Exception("Checkpoint was
declined (tasks not ready)");
- onCompletionPromise.completeExceptionally(cause);
- reportFailedCheckpoint(cause);
- } finally {
- dispose(true);
- }
+ abortWithCause(new Exception("Checkpoint was declined (tasks
not ready)"));
}
/**
* Aborts the pending checkpoint due to an error.
* @param cause The error's exception.
*/
- public void abortError(Throwable cause) {
+ public void abortError(@Nullable Throwable cause) {
Review comment:
In which situation can `cause` be `null`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
