[
https://issues.apache.org/jira/browse/FLINK-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682913#comment-16682913
]
xueyu commented on FLINK-10847:
-------------------------------
It looks that when select multiple distinct aggregate with different arguments
calcite will rewrite using inner join on IS_NOT_DISTINCT_FROM [1]. So it may be
actually the same issue with FLINK-10845 or at least FLINK-10845 depends on
this issue. I submit a PR for FLINK-10845 and hopes it could also solve this
issue at the same time...
IS_NOT_DISTINCT_FROM is almost the same with equal except that it has null
value process, so I just fix based on generateEqual...
When you have time please have a review, thanks~ [~hequn8128][~twalthr]
[1]
https://github.com/apache/calcite/blob/branch-1.7/core/src/main/java/org/apache/calcite/rel/rules/AggregateExpandDistinctAggregatesRule.java#L572
> Add support for IS NOT DISTINCT FROM in code generator
> ------------------------------------------------------
>
> Key: FLINK-10847
> URL: https://issues.apache.org/jira/browse/FLINK-10847
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Hequn Cheng
> Priority: Major
>
> It seems that sometimes {{IS NOT DISTINCT FROM}} is not rewritten by Calcite,
> thus we should have built-in support for it and add more tests. It is already
> officially documented.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
