[
https://issues.apache.org/jira/browse/FLINK-10835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683140#comment-16683140
]
ASF GitHub Bot commented on FLINK-10835:
----------------------------------------
zhijiangW commented on issue #7069: [FLINK-10835][network] Remove duplicated
round-robin ChannelSelector implementation
URL: https://github.com/apache/flink/pull/7069#issuecomment-437733949
@pnowojski , thanks for reviews and suggestions. I will copy the description
to the commit next time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove duplicated Round-robin ChannelSelector implementation in
> RecordWriterTest
> --------------------------------------------------------------------------------
>
> Key: FLINK-10835
> URL: https://issues.apache.org/jira/browse/FLINK-10835
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.8.0
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> {{RoundRobinChannelSelector}} exists for default selector in {{RecordWriter}}
> mainly for tests. Another similar {{RoundRobin}} implementation exists in
> {{RecordWriterTest}}, only because the difference in starting channel index
> for round-robin.
> We can adjust the test verify logic to keep the same behavior with
> {{RoundRobinChannelSelector}}, and then remove the duplicated {{RoundRobin}}.
> It can make simple in following work
> [FLINK-10622|https://issues.apache.org/jira/browse/FLINK-10662]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
