[
https://issues.apache.org/jira/browse/FLINK-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhijiang updated FLINK-10820:
-----------------------------
Description:
_The current {{RebalancePartitioner}} implementation seems a little hacky for
selecting a random number as the first channel index, and the following
selections based on this random index in round-robin fashion._
_Especially for the corner case of {{numChannels = Integer.MAX_VALUE}}, it
would trigger next random index once reaching the last channel index. Actually
the random index should be selected only once at the first time._
was:
The current {{RebalancePartitioner}} implementations seems a little hacky for
selecting a random number as the first channel index, and the following
selections based on this random index in round-robin fashion.
We can define a constant as the first channel index to make the implementation
simple and readable. To do so, it will not change the rebalance semantics.
> Simplify the RebalancePartitioner implementation
> ------------------------------------------------
>
> Key: FLINK-10820
> URL: https://issues.apache.org/jira/browse/FLINK-10820
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.8.0
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
>
> _The current {{RebalancePartitioner}} implementation seems a little hacky for
> selecting a random number as the first channel index, and the following
> selections based on this random index in round-robin fashion._
> _Especially for the corner case of {{numChannels = Integer.MAX_VALUE}}, it
> would trigger next random index once reaching the last channel index.
> Actually the random index should be selected only once at the first time._
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
