[
https://issues.apache.org/jira/browse/FLINK-10821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683664#comment-16683664
]
ASF GitHub Bot commented on FLINK-10821:
----------------------------------------
tillrohrmann closed pull request #7072: [FLINK-10821] Fix resume from
externalized checkpoints E2E Test
URL: https://github.com/apache/flink/pull/7072
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-end-to-end-tests/test-scripts/test_resume_externalized_checkpoints.sh
b/flink-end-to-end-tests/test-scripts/test_resume_externalized_checkpoints.sh
index e1ba65d70c3..fe2319063b5 100755
---
a/flink-end-to-end-tests/test-scripts/test_resume_externalized_checkpoints.sh
+++
b/flink-end-to-end-tests/test-scripts/test_resume_externalized_checkpoints.sh
@@ -66,8 +66,9 @@
TEST_PROGRAM_JAR=${END_TO_END_DIR}/flink-datastream-allround-test/target/DataStr
function buildBaseJobCmd {
local dop=$1
+ local flink_args="$2"
- echo "$FLINK_DIR/bin/flink run -d -p $dop $TEST_PROGRAM_JAR \
+ echo "$FLINK_DIR/bin/flink run -d ${flink_args} -p $dop $TEST_PROGRAM_JAR \
--test.semantics exactly-once \
--environment.parallelism $dop \
--environment.externalize_checkpoint true \
@@ -125,9 +126,20 @@ fi
echo "Restoring job with externalized checkpoint at $CHECKPOINT_PATH ..."
-BASE_JOB_CMD=`buildBaseJobCmd $NEW_DOP`
+BASE_JOB_CMD=`buildBaseJobCmd $NEW_DOP "-s file://${CHECKPOINT_PATH}"`
+JOB_CMD=""
+if [[ $SIMULATE_FAILURE == "true" ]]; then
+ JOB_CMD="$BASE_JOB_CMD \
+ --test.simulate_failure true \
+ --test.simulate_failure.num_records 0 \
+ --test.simulate_failure.num_checkpoints 0 \
+ --test.simulate_failure.max_failures 0 \
+ --environment.restart_strategy no_restart"
+else
+ JOB_CMD=$BASE_JOB_CMD
+fi
-DATASTREAM_JOB=$($BASE_JOB_CMD | grep "Job has been submitted with JobID" |
sed 's/.* //g')
+DATASTREAM_JOB=$($JOB_CMD | grep "Job has been submitted with JobID" | sed
's/.* //g')
wait_job_running $DATASTREAM_JOB
wait_oper_metric_num_in_records SemanticsCheckMapper.0 200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resuming Externalized Checkpoint E2E test does not resume from Externalized
> Checkpoint
> --------------------------------------------------------------------------------------
>
> Key: FLINK-10821
> URL: https://issues.apache.org/jira/browse/FLINK-10821
> Project: Flink
> Issue Type: Bug
> Components: E2E Tests
> Affects Versions: 1.7.0
> Reporter: Gary Yao
> Assignee: Igal Shilman
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Path to externalized checkpoint is not passed as the {{-s}} argument:
> https://github.com/apache/flink/blob/483507a65c7547347eaafb21a24967c470f94ed6/flink-end-to-end-tests/test-scripts/test_resume_externalized_checkpoints.sh#L128
> That is, the test currently restarts the job without checkpoint.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
