nielsbasjes commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-437922403 From the review comments a few points remain open for me: Both are about the way the 'testing' code is part of the code base: - The stopping of the Source (Bound being a separate Source) - The connection to the local PubSub emulator (hostAndPort). How do we proceed on these points?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
