[
https://issues.apache.org/jira/browse/FLINK-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684912#comment-16684912
]
ASF GitHub Bot commented on FLINK-10624:
----------------------------------------
twalthr commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-438189527
@yanghua I agree with @pnowojski. We should test Kafka and Elastic but we
don't need to test them together. The `Executing SQL: Match recognize ->
Elasticsearch` test was meant for testing the new `MATCH_RECOGNIZE` it must not
use Elasticsearch or Kafka. I guess the reason why Kafka was chosen is because
it is the only supported way of having time attributes in the SQL Client so far.
I think we should split the current SQL client test into a Kafka 0.10 test
and a main SQL Client test (that always uses the most recent Kafka version, ES
version etc.). This means we don't have a test regression but don't test
everything for every connector version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Extend SQL client end-to-end to test new KafkaTableSink
> -------------------------------------------------------
>
> Key: FLINK-10624
> URL: https://issues.apache.org/jira/browse/FLINK-10624
> Project: Flink
> Issue Type: Sub-task
> Components: Kafka Connector, Table API & SQL, Tests
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> With FLINK-9697, we added support for Kafka 2.0. We should also extend the
> existing streaming client end-to-end test to also test the new
> {{KafkaTableSink}} against Kafka 2.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
